Disburse maturity destination input #3284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuntaner
reviewed
Sep 12, 2023
mstrasinskis
commented
Sep 12, 2023
| @@ -0,0 +1,92 @@ | |||
| <script lang="ts"> | |||
There was a problem hiding this comment.
A component just to isolate the inputs logic
mstrasinskis
commented
Sep 12, 2023
| } | ||
|
|
||
| .destination-key { | ||
| white-space: nowrap; |
There was a problem hiding this comment.
A request to not break "To address:" line.
mstrasinskis
commented
Sep 12, 2023
| } | ||
|
|
||
| .destination-value { | ||
| text-align: right; |
There was a problem hiding this comment.
The value according to design needs to be right aligned. It feels that KeyValue component needs a review w/ designer.
lmuntaner
force-pushed
the
disburse-maturity-destination-input
branch
from
b0b85bf to
900a72e
Compare
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
# Motivation Improving the disburse maturity flow. This PR is one of the few I'll do to split #3284 into smaller PRs. In this PR, we add the amount of maturity in the component where a percentage of maturity is selected. # Changes * New sns neuron util `maturityPercentageToE8s`. * Use new sns neuron util in NeuronSelectPercantage to show the amount of maturity related to the percentage. # Tests * Test new util. * Test that the amount of maturity is visible in the DisburseMaturityModal. # Todos - [x] Add entry to changelog (if necessary).
|
Obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add destination address support (any icrc address) to disburse maturity modal and minor design/copy changes.
Changes
toAccountfield to disburseMaturity serviceNeuronSelectMaturityDisbursementcomponent to combine maturity disbursement configurationTests
Todos
Not necessary.
Screenshots