Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIX-1683: SnsNeuronPageHeading & PageHeading #2878

Merged
merged 1 commit into from
Jul 14, 2023
Merged

GIX-1683: SnsNeuronPageHeading & PageHeading #2878

merged 1 commit into from
Jul 14, 2023

Conversation

lmuntaner
Copy link
Contributor

Motivation

We are reshuffling how the data is displayed in the neuron detail page.

In this PR: Introduce the new heading component for the SNS neuron detail page.

Changes

  • New component in common PageHeading.
  • NnsNeuronPageHeader uses the new PageHeading.
  • New component SnsNeuronPageHeading that also uses PageHeading.
  • Add a wrapper that sets spacing for the new components of SnsNeuronDetailPage and render the new SnsNeuronPageHeading and a separator.

Tests

  • Spec file for new component SnsNeuronPageHeading.

Todos

Changes not worth still a changelog entry.

@lmuntaner
Copy link
Contributor Author

New UI component:

Screenshot 2023-07-13 at 14 02 20

It has the same spacing problem as the NnsNeuronPageHeading 😢

@lmuntaner
Copy link
Contributor Author

@mstrasinskis @peterpeterparker please review

mstrasinskis
mstrasinskis approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

frontend/src/lib/components/sns-neuron-detail/SnsNeuronPageHeading.svelte Show resolved Hide resolved
@lmuntaner lmuntaner added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit f99b0fd Jul 14, 2023
@lmuntaner lmuntaner deleted the GIX-1683_LM_SnsNeuronPageHeading branch July 14, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @mstrasinskis