Skip to content

Commit

Permalink
adds tests
Browse files Browse the repository at this point in the history
  • Loading branch information
yhabib committed Dec 5, 2024
1 parent 9282d80 commit 3dc37c3
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 2 deletions.
7 changes: 5 additions & 2 deletions frontend/src/lib/components/header/AccountMenu.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import LoginIconOnly from "./LoginIconOnly.svelte";
import Logout from "./Logout.svelte";
import { IconUser, Popover } from "@dfinity/gix-components";
import ExportIcpTransactionsButton from "$lib/components/header/ExportIcpTransactionsButton.svelte";
import ExportIcpTransactionsButton from "$lib/components/header/ExportIcpTransactionsButton.svelte";
let visible = false;
let button: HTMLButtonElement | undefined;
Expand Down Expand Up @@ -44,7 +44,10 @@

{#if $ENABLE_EXPORT_NEURONS_REPORT}
<ExportNeuronsButton on:nnsExportNeuronsCsvTriggered={toggle} />
<ExportIcpTransactionsButton on:nnsExportIcpTransactionsCsvTriggered={toggle} />

<ExportIcpTransactionsButton
on:nnsExportIcpTransactionsCsvTriggered={toggle}
/>
{/if}

<Logout on:nnsLogoutTriggered={toggle} />
Expand Down
36 changes: 36 additions & 0 deletions frontend/src/tests/lib/components/header/AccountMenu.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,42 @@ describe("AccountMenu", () => {
expect(await accountMenuPo.isOpen()).toBe(false);
});
});

it("should not show the Export ICP Transactions Report button if feature flag is off(by default)", async () => {
const { accountMenuPo } = renderComponent();

await accountMenuPo.openMenu();

expect(
await accountMenuPo.getExportIcpTransactionsButtonPo().isPresent()
).toBe(false);
});

it("should show Export Icp Transactinos Report button if feature flag is on", async () => {
overrideFeatureFlagsStore.setFlag("ENABLE_EXPORT_NEURONS_REPORT", true);
const { accountMenuPo } = renderComponent();

await accountMenuPo.openMenu();

expect(
await accountMenuPo.getExportIcpTransactionsButtonPo().isPresent()
).toBe(true);
});

it("should close the menu once the Export Icp Transactions Report button is clicked", async () => {
overrideFeatureFlagsStore.setFlag("ENABLE_EXPORT_NEURONS_REPORT", true);
const { accountMenuPo } = renderComponent();

expect(await accountMenuPo.isOpen()).toBe(false);

await accountMenuPo.openMenu();
expect(await accountMenuPo.isOpen()).toBe(true);

await accountMenuPo.getExportIcpTransactionsButtonPo().click();
await waitFor(async () => {
expect(await accountMenuPo.isOpen()).toBe(false);
});
});
});
});
});
5 changes: 5 additions & 0 deletions frontend/src/tests/page-objects/AccountMenu.page-object.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { BasePageObject } from "$tests/page-objects/base.page-object";
import { ButtonPo } from "$tests/page-objects/Button.page-object";
import { ExportIcpTransactionsButtonPo } from "$tests/page-objects/ExportIcpTransactionsButton.page-object";
import { ExportNeuronsButtonPo } from "$tests/page-objects/ExportNeuronsButton.page-object";
import type { PageObjectElement } from "$tests/types/page-object.types";
import { AccountDetailsPo } from "./AccountDetails.page-object";
Expand Down Expand Up @@ -70,4 +71,8 @@ export class AccountMenuPo extends BasePageObject {
getExportNeuronsButtonPo(): ExportNeuronsButtonPo {
return ExportNeuronsButtonPo.under({ element: this.root });
}

getExportIcpTransactionsButtonPo(): ExportIcpTransactionsButtonPo {
return ExportIcpTransactionsButtonPo.under({ element: this.root });
}
}

0 comments on commit 3dc37c3

Please sign in to comment.