Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Canister Snapshots #4679

Merged
merged 11 commits into from
Oct 17, 2024
Merged

Test Canister Snapshots #4679

merged 11 commits into from
Oct 17, 2024

Conversation

luc-blaeser
Copy link
Contributor

@luc-blaeser luc-blaeser commented Aug 30, 2024 •
edited
Loading

Test canister snapshot with classical and enhanced orthogonal persistence.

Requires a more recent drun version with snapshot fix: luc-blaeser/ic@58b86e6

@luc-blaeser luc-blaeser marked this pull request as ready for review August 30, 2024 10:01
@luc-blaeser luc-blaeser self-assigned this Aug 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

Comparing from d50b53c to 4a8f23e:
The produced WebAssembly code seems to be completely unchanged.

@luc-blaeser luc-blaeser added the testing Related to test suite label Sep 2, 2024
@luc-blaeser luc-blaeser changed the base branch from luc/upgrade-drun to master October 16, 2024 11:46
crusso
crusso approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Might make a good example with a little rewriting to avoid Prim...

@luc-blaeser
Copy link
Contributor Author

Nice. Might make a good example with a little rewriting to avoid Prim...

Thank you. Indeed, we could add this to the example set (with proper base-lib imports).

@luc-blaeser luc-blaeser added the automerge-squash When ready, merge (using squash) label Oct 16, 2024
@mergify mergify bot merged commit d8e8726 into master Oct 17, 2024
10 checks passed
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Oct 17, 2024
@mergify mergify bot deleted the luc/test-canister-snapshots branch October 17, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

@ggreif ggreif Awaiting requested review from ggreif

Assignees

@luc-blaeser luc-blaeser

Labels
testing Related to test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luc-blaeser @crusso