Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use repr(C) in RTS struct #2788

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Use repr(C) in RTS struct #2788

merged 3 commits into from
Sep 16, 2021

Conversation

osa1
Copy link
Contributor

@osa1 osa1 commented Sep 16, 2021

See the node added with this commit and
#2761 (comment) for
the problem this solves.

@osa1
Use repr(C) in RTS struct
7df9955 
See the node added with this commit and
#2761 (comment) for
the problem this solves.
@github-actions
Copy link

github-actions bot commented Sep 16, 2021 •
edited
Loading

Comparing from 9b24b7b to 8e224f5:
In terms of gas, 1 tests regressed and the mean change is +0.0%.
In terms of size, 3 tests improved and the mean change is -0.0%.

ggreif
ggreif reviewed Sep 16, 2021
View reviewed changes
rts/motoko-rts/src/types.rs Outdated Show resolved Hide resolved
nomeata
nomeata approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for a great note

@osa1 osa1 added the automerge-squash When ready, merge (using squash) label Sep 16, 2021
@mergify mergify bot merged commit a71a21b into master Sep 16, 2021
@mergify mergify bot deleted the osa1/struct_repr_again branch September 16, 2021 15:18
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif left review comments

@nomeata nomeata nomeata approved these changes

@crusso crusso Awaiting requested review from crusso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osa1 @nomeata @ggreif