-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use nix-build-uncached to speed up CI jobs #2747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before, the `nix-build` step would build or download everything defined in the `default.nix` file. But there is no point in downloading stuff from the cache here; if it is there, all is well. The [`nix-build-uncached` tool](https://github.com/Mic92/nix-build-uncached) supposedly fixes that. So let’s try.
crusso
reviewed
Aug 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubberstamping
crusso
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving
nomeata
added a commit
to nomeata/ic-hs
that referenced
this pull request
Sep 14, 2021
this should noticably speed up CI runs that don’t have to build everything (e.g. when only tests change). Tried and proven in Motoko already (dfinity/motoko#2747)
marcin-dziadus
pushed a commit
to dfinity/ic-hs
that referenced
this pull request
Sep 15, 2021
this should noticably speed up CI runs that don’t have to build everything (e.g. when only tests change). Tried and proven in Motoko already (dfinity/motoko#2747)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, the
nix-build
step would build or download everything defined in thedefault.nix
file. But there is no point in downloading stuff from thecache here; if it is there, all is well.
The
nix-build-uncached
tool supposedly fixes that. So let’s try.