Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile.ml: Provide fixed arity versions of share_code #214

Merged
merged 1 commit into from
Mar 6, 2019
Merged

compile.ml: Provide fixed arity versions of share_code #214

merged 1 commit into from
Mar 6, 2019

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Mar 5, 2019

less code, and no need to get the index right.

ggreif
ggreif approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits only, LGTM.

src/compile.ml Outdated Show resolved Hide resolved
src/compile.ml Outdated Show resolved Hide resolved
src/compile.ml Outdated Show resolved Hide resolved
src/compile.ml Outdated Show resolved Hide resolved
@nomeata
compile.ml: Provide fixed arity versions of share_code
7118eb9 
less code, and no need to get the index right.
@nomeata nomeata merged commit c97c0c7 into master Mar 6, 2019
@nomeata nomeata deleted the joachim/share_code_arity branch March 6, 2019 11:00
dfinity-bot added a commit that referenced this pull request Dec 6, 2020
@dfinity-bot
niv musl-wasi: update 9083fe84 -> 378fd4b2
e11b5c7 
## Changelog for musl-wasi:
Branch: master
Commits: [WebAssembly/wasi-libc@9083fe84...378fd4b2](WebAssembly/wasi-libc@9083fe8...378fd4b)

* [`5b148b61`](WebAssembly/wasi-libc@5b148b6) Add basic emulation of getcwd/chdir ([WebAssembly/wasi-libc⁠#214](http://r.duckduckgo.com/l/?uddg=https://github.com/WebAssembly/wasi-libc/issues/214))
* [`58795582`](WebAssembly/wasi-libc@5879558) Update to musl 1.2.1. ([WebAssembly/wasi-libc⁠#222](http://r.duckduckgo.com/l/?uddg=https://github.com/WebAssembly/wasi-libc/issues/222))
* [`424d0582`](WebAssembly/wasi-libc@424d058) Fix sinh's sign handling
* [`378fd4b2`](WebAssembly/wasi-libc@378fd4b) windows ci: try moving rustup stuff to non-bash shell ([WebAssembly/wasi-libc⁠#225](http://r.duckduckgo.com/l/?uddg=https://github.com/WebAssembly/wasi-libc/issues/225))
dfinity-bot added a commit that referenced this pull request Dec 7, 2020
@dfinity-bot
niv musl-wasi: update 9083fe84 -> 378fd4b2
6fe3a51 
## Changelog for musl-wasi:
Branch: master
Commits: [WebAssembly/wasi-libc@9083fe84...378fd4b2](WebAssembly/wasi-libc@9083fe8...378fd4b)

* [`5b148b61`](WebAssembly/wasi-libc@5b148b6) Add basic emulation of getcwd/chdir ([WebAssembly/wasi-libc⁠#214](http://r.duckduckgo.com/l/?uddg=https://github.com/WebAssembly/wasi-libc/issues/214))
* [`58795582`](WebAssembly/wasi-libc@5879558) Update to musl 1.2.1. ([WebAssembly/wasi-libc⁠#222](http://r.duckduckgo.com/l/?uddg=https://github.com/WebAssembly/wasi-libc/issues/222))
* [`424d0582`](WebAssembly/wasi-libc@424d058) Fix sinh's sign handling
* [`378fd4b2`](WebAssembly/wasi-libc@378fd4b) windows ci: try moving rustup stuff to non-bash shell ([WebAssembly/wasi-libc⁠#225](http://r.duckduckgo.com/l/?uddg=https://github.com/WebAssembly/wasi-libc/issues/225))
mergify bot pushed a commit that referenced this pull request Dec 7, 2020
@dfinity-bot
niv musl-wasi: update 9083fe84 -> 378fd4b2 (#2186)
1cb9da0 
## Changelog for musl-wasi:
Branch: master
Commits: [WebAssembly/wasi-libc@9083fe84...378fd4b2](WebAssembly/wasi-libc@9083fe8...378fd4b)

* [`5b148b61`](WebAssembly/wasi-libc@5b148b6) Add basic emulation of getcwd/chdir ([WebAssembly/wasi-libc⁠#214](http://r.duckduckgo.com/l/?uddg=https://github.com/WebAssembly/wasi-libc/issues/214))
* [`58795582`](WebAssembly/wasi-libc@5879558) Update to musl 1.2.1. ([WebAssembly/wasi-libc⁠#222](http://r.duckduckgo.com/l/?uddg=https://github.com/WebAssembly/wasi-libc/issues/222))
* [`424d0582`](WebAssembly/wasi-libc@424d058) Fix sinh's sign handling
* [`378fd4b2`](WebAssembly/wasi-libc@378fd4b) windows ci: try moving rustup stuff to non-bash shell ([WebAssembly/wasi-libc⁠#225](http://r.duckduckgo.com/l/?uddg=https://github.com/WebAssembly/wasi-libc/issues/225))
dfinity-bot added a commit that referenced this pull request Jul 19, 2023
@dfinity-bot
niv ic-hs: update e727feca -> f718f74d
94ff12b 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...f718f74d](dfinity/ic-hs@e727fec...f718f74)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://togithub.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://togithub.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://togithub.com/dfinity/ic-hs/issues/215))
dfinity-bot added a commit that referenced this pull request Jul 20, 2023
@dfinity-bot
niv ic-hs: update e727feca -> f718f74d
8fff86f 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...f718f74d](dfinity/ic-hs@e727fec...f718f74)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://togithub.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://togithub.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://togithub.com/dfinity/ic-hs/issues/215))
dfinity-bot added a commit that referenced this pull request Jul 24, 2023
@dfinity-bot
niv ic-hs: update e727feca -> f718f74d
5dccafd 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...f718f74d](dfinity/ic-hs@e727fec...f718f74)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://togithub.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://togithub.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://togithub.com/dfinity/ic-hs/issues/215))
dfinity-bot added a commit that referenced this pull request Aug 11, 2023
@dfinity-bot
niv ic-hs: update e727feca -> a5f89cf5
85a4696 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...a5f89cf5](dfinity/ic-hs@e727fec...a5f89cf)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://togithub.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://togithub.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://togithub.com/dfinity/ic-hs/issues/215))
* [`a5f89cf5`](dfinity/ic-hs@a5f89cf) add note that DFINITY stopped contributing ([dfinity/ic-hs⁠#216](https://togithub.com/dfinity/ic-hs/issues/216))
mergify bot pushed a commit that referenced this pull request Aug 11, 2023
@dfinity-bot
niv ic-hs: update e727feca -> a5f89cf5 (#4134)
b120a20 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...a5f89cf5](dfinity/ic-hs@e727fec...a5f89cf)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://togithub.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://togithub.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://togithub.com/dfinity/ic-hs/issues/215))
* [`a5f89cf5`](dfinity/ic-hs@a5f89cf) add note that DFINITY stopped contributing ([dfinity/ic-hs⁠#216](https://togithub.com/dfinity/ic-hs/issues/216))
dfinity-bot added a commit that referenced this pull request Aug 27, 2024
@dfinity-bot
niv ic-hs: update e727feca -> a5f89cf5
47717c4 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...a5f89cf5](dfinity/ic-hs@e727fec...a5f89cf)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://togithub.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://togithub.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://togithub.com/dfinity/ic-hs/issues/215))
* [`a5f89cf5`](dfinity/ic-hs@a5f89cf) add note that DFINITY stopped contributing ([dfinity/ic-hs⁠#216](https://togithub.com/dfinity/ic-hs/issues/216))
mergify bot pushed a commit that referenced this pull request Aug 27, 2024
@dfinity-bot
niv ic-hs: update e727feca -> a5f89cf5 (#4672)
bbffe06 
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...a5f89cf5](dfinity/ic-hs@e727fec...a5f89cf)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://togithub.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://togithub.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://togithub.com/dfinity/ic-hs/issues/215))
* [`a5f89cf5`](dfinity/ic-hs@a5f89cf) add note that DFINITY stopped contributing ([dfinity/ic-hs⁠#216](https://togithub.com/dfinity/ic-hs/issues/216))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nomeata @ggreif