feat(PocketIC): make PocketIC library run on Windows seamlessly #2138
+78
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
commented
Oct 20, 2024
| @@ -1354,6 +1355,7 @@ fn subnet_metrics() { | |||
| assert!((1 << 16) < metrics.canister_state_bytes && metrics.canister_state_bytes < (1 << 17)); | |||
| } | |||
|
|
|||
| #[cfg(unix)] | |||
There was a problem hiding this comment.
Note for reviewers: this test fails on Windows because localhost subdomains (http://<canister-id>.localhost) are not supported on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes canister tests using the PocketIC library run seamlessly on Windows:
--pidof the PocketIC server and makes the CLI option--port-filebehave like--pid: only one PocketIC server process listens at a port and writes that port to the specified port file. This change was necessary because the (implicit) port file created using--pidin a WSL temporary directory cannot be read from a native Windowscargo testinvokation;This PR has been tested manually by running
cargo test -p pocket-icon a Windows laptop. It is not possible to have a CI test on a Windows runner because they only support WSLv1, but WSLv2 is required (see forum post).