Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not return an HTTP error for calls to stopping/stopped canisters #115

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Nov 29, 2022

Calls to stopping/stopped canisters should not be rejected with an HTTP error (see API Request submission which can succeed even if the canister is not running). Instead, the request should go through the states received, processing, and finally rejected.

@mraszyk mraszyk requested a review from nomeata November 29, 2022 17:00
@mraszyk mraszyk merged commit 20e23e1 into master Nov 30, 2022
@mraszyk mraszyk deleted the mraszyk/calls-to-not-running-canisters branch November 30, 2022 12:28
@mraszyk
Copy link
Contributor Author

mraszyk commented Nov 30, 2022

@nomeata Thank you for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants