New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trailing comma in TypeScript bindings #389

Merged

chenyan-dfinity merged 2 commits into master from ryan/typescript-trailing-comma

Oct 13, 2022

Contributor

rvanasa commented Oct 13, 2022 •

edited

Loading

Removes trailing commas from generated TS type parameters (microsoft/TypeScript#21984).

rvanasa added 2 commits

October 13, 2022 11:07


          Fix: trailing comma in TypeScript bindings

fbf0513


          Regenerate golden files

f84e938

github-actions bot commented Oct 13, 2022

Benchmark for `03c55b5`

Click to view benchmark

Test	Base	PR	%
Blob/&str	215.7±120.96µs	208.2±119.90µs	-3.48%
Blob/ByteBuf	141.2±48.18µs	138.2±49.35µs	-2.12%
Blob/Bytes	111.8±46.25µs	102.1±45.11µs	-8.68%
Blob/String	251.3±128.18µs	242.6±131.05µs	-3.46%
Collections/vec (text, nat)	66.0±0.58ms	66.3±0.66ms	+0.45%
Collections/vec int	31.8±0.18ms	31.6±0.07ms	-0.63%
Collections/vec int64	21.9±0.20ms	21.7±0.18ms	-0.91%
Collections/vec nat8	17.5±0.07ms	17.7±0.08ms	+1.14%
option list/1024	2.5±0.01ms	2.6±0.02ms	+4.00%
profiles/1024	4.3±0.01ms	4.4±0.02ms	+2.33%
variant list/1024	2.3±0.01ms	2.7±0.01ms	+17.39%

rvanasa requested a review from chenyan-dfinity

October 13, 2022 17:33

chenyan-dfinity approved these changes

View reviewed changes

chenyan-dfinity merged commit 646f5dd into master

chenyan-dfinity deleted the ryan/typescript-trailing-comma branch

October 13, 2022 19:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet