Updated Jasmine-core to a dependency of version 3.2 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
footballencarta
changed the title
dfederm
requested changes
Aug 20, 2018
package.json
Outdated
| } | ||
| ], | ||
| "dependencies": { | ||
| "jasmine-core": ">=3.2" |
There was a problem hiding this comment.
Isn't peerDependencies the right place to have this though? This package is a plugin, so typically you want all users of this package to explicitly have jasmine also in their package.json, rather than letting it be pulled in as a dependency of the plugin.
Relevant SO post: https://stackoverflow.com/a/34645112/7065632
Thoughts?
|
No problem - file updated :) Seems I've learnt something about peerDependancies today! |
dfederm
reviewed
Aug 20, 2018
package-lock.json
Outdated
| "resolved": "https://registry.npmjs.org/jasmine-core/-/jasmine-core-3.2.0.tgz", | ||
| "integrity": "sha512-35OOToo2lFczwZ/FdJkUOO/Gsp9FW7viWChYA7OgBfpjgTxbxmNKyNrGS3HHREHay5nJwJvu4RqAlvcBcCAWeA==", | ||
| "version": "3.2.1", | ||
| "resolved": "http://npm-packages.rmdev.zone/jasmine-core/-/jasmine-core-3.2.1.tgz", |
There was a problem hiding this comment.
Hmm, this doesn't seem right? Do you have a non-standard proxy set up or something? (Sorry I didn't notice this earlier)
There was a problem hiding this comment.
Yes we do - good spot, I didn't notice it either :)
added 2 commits
August 20, 2018 17:05
dfederm
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing #14 - jasmine 3.2 is now required for the latest version of the plugin to work.
Added it as a dependancy to allow projects to pick up the package difference and process accordingly.