EES-5446 - making data processor and PSQL deploys independent of priv…

…ate DNS zone deployment to save lots of time during a standard deploy

infrastructure/templates/public-api/ci/tasks/wait-for-endpoint-success.yml

@@ -1,24 +1,18 @@
 parameters:
-
   - name: serviceConnection
     type: string
-
   - name: displayName
     type: string
     default: Waiting for a successful response from endpoint
-
   - name: accessTokenScope
     type: string
     default: null
-
   - name: pollingDelaySeconds
     type: number
     default: 5
-
   - name: maxAttempts
     type: number
     default: 50
-
   - name: endpoint
     type: string
 
@@ -60,4 +54,4 @@ steps:
         done
 
         echo "Timed out waiting for successful response."
-        exit 1
+        exit 1

infrastructure/templates/public-api/ci/tasks/wait-for-orchestrations-to-complete.yml

@@ -1,30 +1,22 @@
 parameters:
-
   - name: serviceConnection
     type: string
-
   - name: displayName
     type: string
     default: Waiting for active orchestrations to complete
-
   - name: condition
     type: string
-
   - name: accessTokenScope
     type: string
     default: null
-
   - name: pollingDelaySeconds
     type: number
     default: 5
-
   - name: maxAttempts
     type: number
     default: 50
-
   - name: endpoint
     type: string
-
   - name: dependsOn
     type: object
     default: []
@@ -71,4 +63,4 @@ steps:
         done
 
         echo "Timed out waiting for active orchestrations to complete."
-        exit 1
+        exit 1

infrastructure/templates/public-api/main.bicep

@@ -10,7 +10,7 @@ param location string = resourceGroup().location
 @description('Public API Storage : Size of the file share in GB.')
 param publicApiDataFileShareQuota int = 1
 
-@description('Firewall rules for maintenance of the service by allowing key IP ranges access to resources.')
+@description('Provides access to resources for specific IP address ranges used for service maintenance.')
 param maintenanceIpRanges IpRange[] = []
 
 @description('Database : administrator login name.')
@@ -187,7 +187,7 @@ module coreStorage 'application/shared/coreStorage.bicep' = {
 }
 
 module privateDnsZonesModule 'application/shared/privateDnsZones.bicep' = 
-  if (deploySharedPrivateDnsZones || deployPsqlFlexibleServer || deployDataProcessor) {
+  if (deploySharedPrivateDnsZones) {
   name: 'privateDnsZonesApplicationModuleDeploy'
   params: {
     resourceNames: resourceNames

src/GovUk.Education.ExploreEducationStatistics.Public.Data.Processor/Functions/LongRunningOrchestration.cs

@@ -6,7 +6,7 @@
 
 namespace GovUk.Education.ExploreEducationStatistics.Public.Data.Processor.Functions;
 
-public static class LogRunningOrchestration
+public static class LongRunningOrchestration
 {
     [Function(nameof(ProcessLongRunningOrchestration))]
     public static async Task ProcessLongRunningOrchestration(

src/GovUk.Education.ExploreEducationStatistics.Public.Data.Processor/Functions/LongRunningTriggerFunction.cs

@@ -25,7 +25,7 @@ public async Task<IActionResult> TriggerLongRunningOrchestration(
             httpRequest.GetRequestParamInt(paramName: "durationSeconds", 60);
 
         const string orchestratorName =
-            nameof(LogRunningOrchestration.ProcessLongRunningOrchestration);
+            nameof(LongRunningOrchestration.ProcessLongRunningOrchestration);
 
         var options = new StartOrchestrationOptions { InstanceId = instanceId.ToString() };