Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'this link' to bad_link_text options #60

Merged
merged 1 commit into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/data-bad_link_text.R
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#' https://www.w3.org/WAI/WCAG22/Understanding/link-purpose-in-context).
#'
#' @format ## `bad_link_text`
#' A data frame with 52 rows and 1 columns:
#' A data frame with 53 rows and 1 columns:
#' \describe{
#' \item{bad_link_text}{Lower cased examples of non-descriptive link text}
#' }
Expand Down
3 changes: 2 additions & 1 deletion data-raw/bad_link_text.R
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ bad_link_text <- data.frame(
"download file", "download here", "download jpg", "download jpeg",
"download pdf", "download png", "download svg", "download word",
"download xslx", "further information", "go here", "learn more",
"link to", "read more", "this page", "visit this", "web page", "web site"
"link to", "read more", "this page", "visit this", "web page", "web site",
"this link"
)
)

Expand Down
Binary file modified data/bad_link_text.rda
Binary file not shown.
2 changes: 1 addition & 1 deletion man/bad_link_text.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/testthat/test-data-bad_link_text.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ test_that("Returns data frame", {

test_that("Matches description", {
# If this test fails, update the notes in R/data-bad_link_text.R
expect_equal(nrow(dfeshiny::bad_link_text), 52)
expect_equal(nrow(dfeshiny::bad_link_text), 53)
expect_equal(names(dfeshiny::bad_link_text), "bad_link_text")
})

Expand Down
Loading