Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie vignette #39

Merged
merged 11 commits into from
Jul 19, 2024
Merged

Cookie vignette #39

merged 11 commits into from
Jul 19, 2024

Conversation

rmbielby
Copy link
Contributor

Adding a vignette / article page to the pkgdown site explaining how to apply the cookie consent to a dashboard:

Main changes:

  • Description of how to implement cookie consent
  • Removed outdated description from readme

Incidental change:

  • Added explicit setting of an expiry on the cookie consent cookie (365 days)

@rmbielby rmbielby self-assigned this May 13, 2024
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
vignettes/implementing-cookies.Rmd Fixed Show fixed Hide fixed
Copy link
Contributor

@jen-machin jen-machin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for nitpicky comments, hopefully some fairly minor changes here

vignettes/implementing-cookies.Rmd Outdated Show resolved Hide resolved
vignettes/implementing-cookies.Rmd Outdated Show resolved Hide resolved
vignettes/implementing-cookies.Rmd Outdated Show resolved Hide resolved
vignettes/implementing-cookies.Rmd Outdated Show resolved Hide resolved
vignettes/implementing-cookies.Rmd Outdated Show resolved Hide resolved
vignettes/implementing-cookies.Rmd Show resolved Hide resolved
vignettes/implementing-cookies.Rmd Outdated Show resolved Hide resolved
@rmbielby rmbielby requested a review from jen-machin July 17, 2024 08:58
Copy link
Contributor

@jen-machin jen-machin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that one typo to change but everything else looks great!

@rmbielby rmbielby merged commit b19f36f into main Jul 19, 2024
8 checks passed
@rmbielby rmbielby deleted the cookie-vignette branch January 10, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants