Merge pull request #60 from dfe-analytical-services/bad_link_text_add…

…itions add 'this link' to bad_link_text options
dfe-analytical-services · Oct 24, 2024 · d67ffe7 · d67ffe7
2 parents 546f4c1 + 9e0feb3
commit d67ffe7
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/R/data-bad_link_text.R b/R/data-bad_link_text.R
@@ -9,7 +9,7 @@
 #' https://www.w3.org/WAI/WCAG22/Understanding/link-purpose-in-context).
 #'
 #' @format ## `bad_link_text`
-#' A data frame with 52 rows and 1 columns:
+#' A data frame with 53 rows and 1 columns:
 #' \describe{
 #'   \item{bad_link_text}{Lower cased examples of non-descriptive link text}
 #' }

diff --git a/data-raw/bad_link_text.R b/data-raw/bad_link_text.R
@@ -10,7 +10,8 @@ bad_link_text <- data.frame(
     "download file", "download here", "download jpg", "download jpeg",
     "download pdf", "download png", "download svg", "download word",
     "download xslx", "further information", "go here", "learn more",
-    "link to", "read more", "this page", "visit this", "web page", "web site"
+    "link to", "read more", "this page", "visit this", "web page", "web site",
+    "this link"
   )
 )
 

diff --git a/data/bad_link_text.rda b/data/bad_link_text.rda
diff --git a/man/bad_link_text.Rd b/man/bad_link_text.Rd
diff --git a/tests/testthat/test-data-bad_link_text.R b/tests/testthat/test-data-bad_link_text.R
@@ -4,7 +4,7 @@ test_that("Returns data frame", {
 
 test_that("Matches description", {
   # If this test fails, update the notes in R/data-bad_link_text.R
-  expect_equal(nrow(dfeshiny::bad_link_text), 52)
+  expect_equal(nrow(dfeshiny::bad_link_text), 53)
   expect_equal(names(dfeshiny::bad_link_text), "bad_link_text")
 })