Skip to content

Commit

Permalink
style edits
Browse files Browse the repository at this point in the history
  • Loading branch information
alex-rogers-hub committed Dec 16, 2024
1 parent 7648d74 commit 850b990
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions R/bookmark.R
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
#' })
#'
#' observe({
#' # Trigger this observer every time an input changes
#' # Trigger this observer every time an input changes
#' reactiveValuesToList(input)
#' session$doBookmark()
#' })
#' })
#'
#' onBookmarked(function(url) {
#' updateQueryString(url)
#' })
setBookmarkInclude <- function(bookmarkingWhitelist){
#' updateQueryString(url)
#' })
setBookmarkInclude <- function(bookmarkingWhitelist) {

Check notice

Code scanning / lintr

Variable and function name style should match snake_case or symbols. Note

Variable and function name style should match snake_case or symbols.

Check notice

Code scanning / lintr

Variable and function name style should match snake_case or symbols. Note

Variable and function name style should match snake_case or symbols.
# exclude the white list from complete list
toExclude <- setdiff(names(input), bookmarkingWhitelist)

Check notice

Code scanning / lintr

Variable and function name style should match snake_case or symbols. Note

Variable and function name style should match snake_case or symbols.

Check warning

Code scanning / lintr

no visible binding for global variable 'input' Warning

no visible binding for global variable 'input'

Check warning on line 31 in R/bookmark.R

View check run for this annotation

Codecov / codecov/patch

R/bookmark.R#L31

Added line #L31 was not covered by tests

Expand All @@ -36,7 +36,7 @@ setBookmarkInclude <- function(bookmarkingWhitelist){
# exclude all remaining inputs from bookmark
setBookmarkExclude(toExclude)

Check warning

Code scanning / lintr

no visible global function definition for 'setBookmarkExclude' Warning

no visible global function definition for 'setBookmarkExclude'

Check warning on line 37 in R/bookmark.R

View check run for this annotation

Codecov / codecov/patch

R/bookmark.R#L37

Added line #L37 was not covered by tests

print('bookmarked')
print("bookmarked")

Check warning on line 39 in R/bookmark.R

View check run for this annotation

Codecov / codecov/patch

R/bookmark.R#L39

Added line #L39 was not covered by tests
# Trigger bookmarking whenever relevant inputs change
session$doBookmark()

Check warning

Code scanning / lintr

no visible binding for global variable 'session' Warning

no visible binding for global variable 'session'

Check warning on line 41 in R/bookmark.R

View check run for this annotation

Codecov / codecov/patch

R/bookmark.R#L41

Added line #L41 was not covered by tests
}

0 comments on commit 850b990

Please sign in to comment.