Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api permissions on azuread app #1639

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

samidbb
Copy link
Contributor

@samidbb samidbb commented Nov 28, 2024

Describe your changes

Enable requesting api permissions on AzureAD app registrations

Issue ticket number and link

https://github.com/dfds/cloudplatform/issues/2858

Checklist before requesting a review

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@samidbb samidbb added the release:minor Triggers a minor release label Dec 2, 2024
@samidbb samidbb changed the title enable requesting api permissions api permissions on azuread app Dec 2, 2024
@samidbb samidbb marked this pull request as ready for review December 2, 2024 07:35
@samidbb samidbb requested a review from a team as a code owner December 2, 2024 07:35
Copy link
Contributor

@avnes avnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samidbb samidbb merged commit 95fab8e into master Dec 2, 2024
10 checks passed
@samidbb samidbb deleted the feature/azuread-api-permissions branch December 2, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Triggers a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants