Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the OIDC provider is stored in both our supported regions #1254

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

avnes
Copy link
Contributor

@avnes avnes commented Jan 8, 2024

Describe your changes

While working on https://github.com/dfds/cloudplatform/issues/2409 I discovered that updating my database instances could find the OIDC information, because Terraform could not find the /managed/cluster/oidc-provider path in SSM Parameter Store. It turns out that this data is only stored in eu-central-1, and if yoru database instance is in our other supported region (eu-west-1) , Terraform can not find it.

The solution is to make sure that entry is created in SSM for both our regions. I tested this with my sandbox capability account.

Issue ticket number and link

https://github.com/dfds/cloudplatform/issues/2409

Checklist before requesting a review

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@avnes avnes requested a review from a team as a code owner January 8, 2024 13:11
@avnes avnes added the release:minor Triggers a minor release label Jan 8, 2024
Copy link
Contributor

@silviucalin silviucalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Was about to address this as I was having trouble updating an existing RDS instance in my sandbox too.
Thanks!

@avnes avnes merged commit 9d6d8b4 into master Jan 8, 2024
17 of 19 checks passed
@avnes avnes deleted the feature/cloudplatform/issues/2409 branch January 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Triggers a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants