Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate tags variable declaration for postgres #1252

Conversation

jakob-nielsen-dfds
Copy link
Contributor

@jakob-nielsen-dfds jakob-nielsen-dfds commented Jan 4, 2024

Describe your changes

As the tags variable was defined multiple times for the postgres module, using the module would fail with the error Duplicate variable declaration.

Issue ticket number and link

None.

Checklist before requesting a review

  • I have tested changes in my sandbox
  • I have added the needed changes in the test/integration folder to apply my changes in QA. Read the guide on adding environment variables in QA
    • I don't have permissions to see this guide - is this something internal for Cloud Engineering?
  • I have rebased the code to master (or merged in the latest from master)

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code
    - This could go into a patch release. release:patch is not a valid git tag name. So can't tag my branch with this.. Is this a GitHub label instead?

@jakob-nielsen-dfds jakob-nielsen-dfds marked this pull request as ready for review January 5, 2024 08:03
@jakob-nielsen-dfds jakob-nielsen-dfds requested a review from a team as a code owner January 5, 2024 08:03
@avnes avnes added the release:patch Triggers a patch release label Jan 5, 2024
Copy link
Contributor

@avnes avnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for discovering and fixing this issue

@avnes avnes merged commit 4e58ff4 into dfds:master Jan 5, 2024
6 of 13 checks passed
@jakob-nielsen-dfds
Copy link
Contributor Author

Thanks for discovering and fixing this issue

No problem.

The PR template stuff around environment variables is that an internal Cloud Engineering thing? Just for future reference 😊

@samidbb
Copy link
Contributor

samidbb commented Jan 5, 2024

@jakob-nielsen-dfds PR Template is generated on new PRs. CE members should ensure that the applicable items on the checklist has been completed

@jakob-nielsen-dfds jakob-nielsen-dfds deleted the fix/remove_duplicate_tags_var_declaration branch January 5, 2024 09:20
@jakob-nielsen-dfds
Copy link
Contributor Author

@jakob-nielsen-dfds PR Template is generated on new PRs. CE members should ensure that the applicable items on the checklist has been completed

Okay - wasn't clear to me whether it was the creator of the PR who had to complete the checklist 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants