Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use template for REST port config #67

Closed
dfarrell07 opened this issue Mar 20, 2015 · 0 comments
Closed

Use template for REST port config #67

dfarrell07 opened this issue Mar 20, 2015 · 0 comments

Comments

@dfarrell07
Copy link
Owner

We're currently using file_line, which is basically a sed-like Puppet feature for changing a file based on a regex, to configure ODL's REST port.

For consistency with the Karaf config and Puppet best practice norms (I think), it'd be ideal to move to a template for this config.

This is blocking #47, likely also #48.

  # TODO: Is this include needed?
  include stdlib
  # TODO: Better var name (this is from PR #35)
  # TODO: Consider moving to a template, for consistency
  # TODO: Likely need to set user/group/mode
  $myline= "    <Connector port=\"${odl_rest_port}\" protocol=\"HTTP/1.1\""
  file_line { 'tomcatport':
    ensure => present,
    path   => '/opt/opendaylight/configuration/tomcat-server.xml',
    line   => $myline,
    match  => '^\s*<Connector\s*port=\"[0-9]+\"\s*protocol=\"HTTP\/1.1\"$',
  }
@dfarrell07 dfarrell07 self-assigned this Mar 20, 2015
@dfarrell07 dfarrell07 added this to the Release on Forge milestone Mar 20, 2015
dfarrell07 added a commit that referenced this issue Mar 20, 2015
dfarrell07 added a commit that referenced this issue Mar 31, 2015
* All Beaker REST port tests now passing
* Related to #67, closes #73

Signed-off-by: Daniel Farrell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant