Skip to content

Commit

Permalink
Add CodeQL variant analysis scanning
Browse files Browse the repository at this point in the history
This is a different type of static analysis than others we run.

It identified new issues (already fixed) that our other tool missed.

The company that built it was bought by GitHub and the tool is being
integrated into GitHub's security workflow.

Add one unprivileged version of the job to gate PRs and one privileged
version on-merge to report results.

Relates-to: submariner-io/submariner#1970
Signed-off-by: Daniel Farrell <[email protected]>
  • Loading branch information
dfarrell07 committed Aug 30, 2022
1 parent c71c526 commit f6d5ac3
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 0 deletions.
18 changes: 18 additions & 0 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,24 @@ jobs:
- name: Run packagedoc-lint
run: make packagedoc-lint

variant-analysis:
name: Variant Analysis
runs-on: ubuntu-latest
steps:
- name: Check out the repository
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- name: Initialize CodeQL
uses: github/codeql-action/init@2ca79b6fa8d3ec278944088b4aa5f46912db5d63
with:
languages: go
- name: Build code, creating CodeQL database
run: make build
- name: Run CodeQL variant analysis
uses: github/codeql-action/analyze@2ca79b6fa8d3ec278944088b4aa5f46912db5d63
- name: Show CodeQL scan SARIF report
if: always()
run: cat ../results/go.sarif

vulnerability-scan:
name: Vulnerability Scanning
runs-on: ubuntu-latest
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,26 @@ jobs:
args: >
--debug
variant-analysis:
name: Variant Analysis
runs-on: ubuntu-latest
permissions:
security-events: write
steps:
- name: Check out the repository
uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
- name: Initialize CodeQL
uses: github/codeql-action/init@2ca79b6fa8d3ec278944088b4aa5f46912db5d63
with:
languages: go
- name: Build code, creating CodeQL database
run: make build
- name: Run CodeQL variant analysis
uses: github/codeql-action/analyze@2ca79b6fa8d3ec278944088b4aa5f46912db5d63
- name: Show CodeQL scan SARIF report
if: always()
run: cat ../results/go.sarif

vulnerability-scan:
name: Vulnerability Scanning
if: github.repository_owner == 'submariner-io'
Expand Down

0 comments on commit f6d5ac3

Please sign in to comment.