Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best time to buy and sell stock #45

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Best time to buy and sell stock #45

merged 3 commits into from
Oct 4, 2020

Conversation

ushachengan
Copy link

PR for #41

@ushachengan ushachengan mentioned this pull request Oct 4, 2020
Closed
@dexterpuru dexterpuru added Hacktoberfest hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 4, 2020
@dexterpuru
Copy link
Owner

@ushachengan awesome work, code is really good, can you please shift this problem to arrays folders, because this is not much of a DP problem, the one with cool-down could be really good example for DP.

@ushachengan
Copy link
Author

@dexterpuru moved the code inside Array folder. thanks

YourAKShaw
YourAKShaw approved these changes Oct 4, 2020
View reviewed changes
Copy link
Collaborator

@YourAKShaw YourAKShaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ushachengan All good. I have just one tiny request though, always name the folder exactly the name given on Leetcode excluding the problem number. In this case, don't exclude the spaces in between. Kindly keep that in mind from next time.

@YourAKShaw YourAKShaw merged commit 913ecc4 into dexterpuru:master Oct 4, 2020
@ushachengan
Copy link
Author

sure @Ak-Shaw , I will follow that and fix this folder name in my next PR as well.

@YourAKShaw
Copy link
Collaborator

YourAKShaw commented Oct 4, 2020 •
edited
Loading

@ushachengan I've fixed the name of the solution folder from this PR. Just keep that in mind from next time. 😄👍
Also, whenever working on your local setup, sync your forked version of the repo with the original. It'll help a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YourAKShaw YourAKShaw YourAKShaw approved these changes

@dexterpuru dexterpuru dexterpuru approved these changes

Assignees

@ushachengan ushachengan

Labels
Hacktoberfest hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ushachengan @dexterpuru @YourAKShaw