Skip to content

Commit

Permalink
Now that all 3 browser engines are tested
Browse files Browse the repository at this point in the history
in CI on Lambdatest, we don't really need to run them again in the release script.
However, for safety, run them locally on Chrome and Firefox still.
  • Loading branch information
dfahlander committed Dec 18, 2023
1 parent f40ad21 commit f955f5f
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions test/karma.browsers.matrix.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
module.exports = {
// On developers machines, Chrome is most likely to be installed.
local: ['Chrome'],
//local: ['bs_safari_latest_supported'],

// When Lambdatest credentials aren't available, use Chrome and Firefox on Github Actions:
ciLocal: ['Chrome', 'Firefox'],
Expand All @@ -21,11 +20,13 @@ module.exports = {
],

// Test matrix used before every npm publish.
// Note: The script tools/release.sh will run the tests
// locally on Chrome and Firefox. However, this is just an
// extra safety check as all tests must anyway have been successful
// on the CI that tests on all configured browsers in Lambdatest.
pre_npm_publish: [
'remote_chrome',
'remote_edge',
'remote_safari',
'remote_firefox'
'Chrome',
'Firefox'
]
}

0 comments on commit f955f5f

Please sign in to comment.