Remove reference to nonexistent workload identity functionality #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathaniel Irons <[email protected]>
Signed-off-by: Nathaniel Irons <[email protected]>
irons
force-pushed
the
drop-workload-identity
branch
from
5300ca8
to
03c5db5
Compare
nabokihms
approved these changes
Apr 11, 2024
|
@irons @nabokihms seems like this PR can be reverted because the Google Workload Identity functionality was merged in dexidp/dex#2989 |
|
@StepanKuksenko This can be reverted, indeed. I've just tested it out and it works when not providing the JSON |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google connector docs' reference to relying on GKE Workload Identity, instead of hardcoding service account credentials, was merged as part of PR 138. One of the PRs it documents, 2989, implements that functionality, but has been open for ten months.
I would prefer to see PR 2989 merged without delay, and that functionality promptly released, after which this PR could be closed without merging. Failing that, this PR should be merged to remove the inaccurate claim of support for Workload Identity from the Google connector docs. There are several people in the 2989 discussion who've been misled by it, as was I.
Thanks for your time.