Validate audience with entityIssuer if present, use redirectURI otherwise #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
reviewed
Apr 6, 2017
connector/saml/saml.go
Outdated
| @@ -154,6 +154,11 @@ func (c *Config) openConnector(logger logrus.FieldLogger) (*provider, error) { | |||
| return nil, fmt.Errorf("missing required fields %q", missing) | |||
| } | |||
|
|
|||
| // Set EntityIssuer to RedirectURI if it is not set | |||
| if c.EntityIssuer == "" { | |||
There was a problem hiding this comment.
I don't want to send this if EntityIssuer isn't explicitly set. Issuer is optional and since you stated this wasn't a safe assumption I think it's safer to avoid this default.
There was a problem hiding this comment.
Ok, pushed new change
Calpicow
force-pushed
the
audience_validate_fix
branch
2 times, most recently
from
6993e63
to
334a7b3
Compare
ericchiang
reviewed
Apr 6, 2017
| @@ -466,21 +466,25 @@ func (p *provider) validateConditions(assertion *assertion) error { | |||
| } | |||
| } | |||
| // Validates audience | |||
| audienceValue := p.entityIssuer | |||
There was a problem hiding this comment.
This works for me, but do you think it'd be better to make entityIssuer required? I'm a little on the fence, but it seems like this is important when verifying the audience restrictions.
Would like to know what sounds more reasonable to you.
There was a problem hiding this comment.
I think it'll be ok as long as we make it clear in the documentation. Let me add it.
Calpicow
force-pushed
the
audience_validate_fix
branch
from
334a7b3
to
47897f7
Compare
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Validate audience with entityIssuer if present, use redirectURI otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing with the spec, it appears that Audience values refer to EntityIssuer, and not RedirectURI (though in most cases they are the same, but not all).
This sets EntityIssuer to RedirectURI by default if it is not explicitly set, allowing implementations that need it to function correctly.
Spec: http://docs.oasis-open.org/security/saml/Post2.0/sstc-saml-tech-overview-2.0.html
We see that EntityIssuer is
https://sp.example.com/SAML2, but Destination ishttps://sp.example.com/SAML2/SSO/POST