server: fix expiry detection for verification keys #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dghubble
reviewed
Mar 1, 2017
server/rotation.go
Outdated
| @@ -132,7 +132,7 @@ func (k keyRotater) rotate() error { | |||
| i := 0 | |||
|
|
|||
| for _, key := range keys.VerificationKeys { | |||
| if !key.Expiry.After(tNow) { | |||
| if key.Expiry.After(tNow) { | |||
There was a problem hiding this comment.
// key is still valid, include it in the VerificationKeys
rithujohn191
approved these changes
Mar 1, 2017
ericchiang
force-pushed
the
fix-keys-expiry
branch
from
ff35c6f
to
e2e6e0e
Compare
|
@rithujohn191 can you take a look at the PR again? I've added a few more comments to the rotation code. |
ericchiang
commented
Mar 1, 2017
| for _, key := range keys.VerificationKeys { | ||
| if !key.Expiry.After(tNow) { | ||
| if !expired(key) { |
There was a problem hiding this comment.
Only functional change. Everything else is comments and renaming.
rithujohn191
reviewed
Mar 1, 2017
server/rotation.go
Outdated
| // After demoting the signing key, keep the token around for at least | ||
| // the amount of time an ID Token is valid for. This ensures the | ||
| // verification key won't expire until all ID Tokens is could have | ||
| // signed have expired as well. |
There was a problem hiding this comment.
"This ensures the verification key won't expire until all ID Tokens it has signed have expired as well"?
ericchiang
force-pushed
the
fix-keys-expiry
branch
from
e2e6e0e
to
2c4752d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates #828