fix: always retrieve github emails when preferredEmailDomain is set
#3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <[email protected]>
|
@nabokihms any chance this will be merged? |
|
This is a breaking change, so we must mention it in the RM. Overall, it looks decent. Thanks, @thesuperzapper |
nabokihms
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As discussed in dexidp/website#176, even when
preferredEmailDomain(which was added by #2740) is set on the GitHub connector, if the user has a public email on their GitHub profile, it will take precedence over any private one which might match thepreferredEmailDomainselector.This is problematic for organizations which want to use the email filter to assign permissions to employees based on their corporate email, as they must tell users to remove any public emails from their profile.
What this PR does / why we need it
Simply makes it so that we always preform an email check when
preferredEmailDomainis non empty.Special notes for your reviewer
N/A