fix: Do not evaluate skipApproval on approval page #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove evaluation of skipApproval on approval page
What this PR does / why we need it
The Pull Request #2897 caused a bug when using
oauth2.skipApprovalScreen: truetogether with a client settingapproval_prompt=forceduring the request. The tests validated correctly that the user gets redirected to/approvalin this case, but the handler of the approval page contains some code which immediately returns the auth code ifoauth2.skipApprovalScreen: trueis set and ignores theapproval_promptparameter. Since there is a TODO comment to remove this check after some time, I guess it can be removed now to fix that issue.Special notes for your reviewer
Does this PR introduce a user-facing change?