fix: propagate http client to userInfo requests for OIDC connector #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m.nabokikh <[email protected]>
nabokihms
added
the
release-note/ignore
4 tasks
4 tasks
|
I tested it manually in many prod Kubernetes clusters, and it works as expected now. I'm going to merge this PR. It is better to have a working version in the main than to live with the bug (and it blocks release, ofc). |
Cedric-Magnan
pushed a commit
to Cedric-Magnan/dex
that referenced
this pull request
May 29, 2023
…exidp#2781) Signed-off-by: m.nabokikh <[email protected]>
palexster
pushed a commit
to palexster/dex
that referenced
this pull request
Oct 4, 2023
…exidp#2781) Signed-off-by: m.nabokikh <[email protected]>
michaelliau
pushed a commit
to FlockFreight/dex
that referenced
this pull request
Oct 4, 2023
…exidp#2781) Signed-off-by: m.nabokikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: m.nabokikh [email protected]
Overview
Fix for an error (it occurs when the
getUserInfois set to true and a custom ca is used)What this PR does / why we need it
A fix for #1632
Special notes for your reviewer
Does this PR introduce a user-facing change?
This is a fix for the feature that is not released.