Update ent #2428
Merged
Update ent #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
force-pushed
the
update-ent
branch
from
044afc3
to
6299dcc
Compare
|
@nabokihms any ideas what's going wrong here? |
|
I have never seen this before. If you want, I can research the actual cause. |
|
Looking at the error, the returned timestamp is not precise enough. I don't know if that's because of ent or something else. |
sagikazarmark
force-pushed
the
update-ent
branch
from
6299dcc
to
6c7b72a
Compare
sagikazarmark
force-pushed
the
update-ent
branch
from
6c7b72a
to
6aa2c76
Compare
2 tasks
sagikazarmark
force-pushed
the
update-ent
branch
from
ab239d8
to
05b8331
Compare
|
Looks like the problem was with Atlas. I disabled it for now. See the linked issue for details. |
|
I don't know what's with the Docker build these days. |
Signed-off-by: Mark Sagi-Kazar <[email protected]>
Signed-off-by: Mark Sagi-Kazar <[email protected]>
Signed-off-by: Mark Sagi-Kazar <[email protected]>
Signed-off-by: Mark Sagi-Kazar <[email protected]>
Looks like Atlas (the new migration library under Ent) cannot handle precision properly. An issue has been reported to Ent: ent/ent#2454 Signed-off-by: Mark Sagi-Kazar <[email protected]>
sagikazarmark
force-pushed
the
update-ent
branch
from
05b8331
to
9b1a840
Compare
|
@nabokihms can I get a review on this one? I managed to fix the tests. Docker is just...doing it's own thing, I'm gonna ignore that. |
sagikazarmark
added
the
release-note/dependency-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update ent to the latest version.
What this PR does / why we need it
Updates the ent library to the latest version as well as opts-in for the new Atlas migration engine and regenerates generated files.
Special notes for your reviewer
Does this PR introduce a user-facing change?