Code

PKCE implementation#1784

Code

Merged

sagikazarmark merged 35 commits intodexidp:masterdexidp/dex:masterfrom faro-oss:feature/PKCEfaro-oss/dex:feature/PKCECopy head branch name to clipboardOct 26, 2020

+439-53

Commits

Commits on Aug 17, 2020

• Basic implementation of PKCE

  Show description for 2879801
  Teeed

  committed
  2879801

  Copy full SHA for 2879801

Commits on Aug 25, 2020

• @mfmarche on 24 Feb: when code_verifier is set, don't check client_secret

  Show description for 551a292
  HEllRZA

  committed
  551a292

  Copy full SHA for 551a292

• @deric on 16 Jun: return invalid_grant when wrong code_verifier

  Show description for 2688931
  HEllRZA

  committed
  2688931

  Copy full SHA for 2688931

• Enforce PKCE flow on /token when PKCE flow was started on /auth

  Show description for 3c47734
  HEllRZA

  committed
  3c47734

  Copy full SHA for 3c47734

• fixed error messages when mixed PKCE/no PKCE flow.

  Show description for d0fafb0
  HEllRZA

  committed
  d0fafb0

  Copy full SHA for d0fafb0

• server_test.go: Added PKCE error cases on /token endpoint

  Show description for 492fecf
  HEllRZA

  committed
  492fecf

  Copy full SHA for 492fecf

• cleanup: extracted method checkErrorResponse and type TestDefinition

  Show description for 0c80328
  HEllRZA

  committed
  0c80328

  Copy full SHA for 0c80328

• /token endpoint: skip client_secret verification only for grand type authorization_code with PKCE extension

  Show description for 118ab10
  HEllRZA

  committed
  118ab10

  Copy full SHA for 118ab10

• Merge branch 'master' of github.com:dexidp/dex into faro-upstream/PKCE

  Show description for 60b0ec8
  HEllRZA

  committed
  60b0ec8

  Copy full SHA for 60b0ec8

• Allow "Authorization" header in CORS handlers

  Show description for c58264d
  HEllRZA

  committed
  c58264d

  Copy full SHA for c58264d

Commits on Aug 31, 2020

• Add "code_challenge_methods_supported" to discovery endpoint

  Show description for 739beef
  HEllRZA

  committed
  739beef

  Copy full SHA for 739beef

• Merge branch 'master' of github.com:dexidp/dex into faro-upstream/PKCE

  Show description for b79b265
  HEllRZA

  committed
  b79b265

  Copy full SHA for b79b265

• Merge pull request #4 from faro-oss/faro-upstream/feature/PKCE

  Show description for 06f40be
  HEllRZA

  authored
  06f40be

  Copy full SHA for 06f40be

Commits on Sep 10, 2020

• Updated tests (mixed-up comments), added a PKCE test

  Show description for 1683a17
  HEllRZA

  committed
  1683a17

  Copy full SHA for 1683a17

• Merge pull request #5 from faro-oss/faro-upstream/feature/PKCE

  Show description for 369674f
  HEllRZA

  authored
  369674f

  Copy full SHA for 369674f

Commits on Sep 16, 2020

• remove redefinition of providedCodeVerifier, fixed spelling (#6)

  Show description for a1aab00
  HEllRZA

  committed
  a1aab00

  Copy full SHA for a1aab00

Commits on Sep 17, 2020

• Rename struct CodeChallenge to PKCE

  Show description for 7251cd6
  HEllRZA

  committed
  7251cd6

  Copy full SHA for 7251cd6

• PKCE: Check clientSecret when available

  Show description for b24e4d5
  HEllRZA

  committed
  b24e4d5

  Copy full SHA for b24e4d5

• Enable PKCE with public: true

  Show description for 9faf988
  HEllRZA

  committed
  9faf988

  Copy full SHA for 9faf988

• Redirect error on unsupported code_challenge_method

  Show description for a17bfc1
  HEllRZA

  committed
  a17bfc1

  Copy full SHA for a17bfc1

• Reverted go.mod and go.sum to the state of master

  Show description for f78dc9d
  HEllRZA

  committed
  f78dc9d

  Copy full SHA for f78dc9d

• Merge pull request #7 from faro-oss/faro-upstream/feature/PKCE

  Show description for 9b02f80
  HEllRZA

  authored
  9b02f80

  Copy full SHA for 9b02f80

Commits on Sep 21, 2020

• Don't omit client secret check for PKCE

  Show description for 1059ba7
  HEllRZA

  committed
  1059ba7

  Copy full SHA for 1059ba7

Commits on Sep 22, 2020

• Merge pull request #8 from faro-oss/faro-upstream/feature/PKCE

  Show description for d305bc4
  HEllRZA

  authored
  d305bc4

  Copy full SHA for d305bc4

Commits on Oct 5, 2020

• Allow public clients (e.g. with PKCE) to have redirect URIs configured

  Show description for b6e297b
  heidemn-faro

  committed
  b6e297b

  Copy full SHA for b6e297b

• Remove "Authorization" as Accepted Headers on CORS, small fixes

  Show description for 46c6d9d
  HEllRZA

  committed
  46c6d9d

  Copy full SHA for 46c6d9d

• Merge pull request #9 from faro-oss/faro-upstream/feature/PKCE

  Show description for 3e86bb6
  HEllRZA

  authored
  3e86bb6

  Copy full SHA for 3e86bb6

• Revert "Allow public clients (e.g. with PKCE) to have redirect URIs configured"

  Show description for 5435741
  heidemn-faro

  committed
  5435741

  Copy full SHA for 5435741

• Merge pull request #10 from faro-oss/faro-upstream/feature/PKCE

  Show description for 7fcf960
  heidemn-faro

  authored
  7fcf960

  Copy full SHA for 7fcf960

Commits on Oct 14, 2020

• PKCE on client_secret client error message

  Show description for dd6de36
  HEllRZA

  committed
  dd6de36

  Copy full SHA for dd6de36

• Merge pull request #11 from faro-oss/faro-upstream/feature/PKCE

  Show description for 0063431
  HEllRZA

  authored
  0063431

  Copy full SHA for 0063431

Commits on Oct 15, 2020

• Output info message when PKCE without client_secret used on confidential client

  Show description for a3ed229
  HEllRZA

  committed
  a3ed229

  Copy full SHA for a3ed229

• Merge pull request #12 from faro-oss/faro-upstream/feature/PKCE

  Show description for 3b1f1a5
  HEllRZA

  authored
  3b1f1a5

  Copy full SHA for 3b1f1a5

Commits on Oct 16, 2020

• General missing/invalid client_secret message on token endpoint

  Show description for 7b369a6
  HEllRZA

  committed
  7b369a6

  Copy full SHA for 7b369a6

• Merge pull request #13 from faro-oss/faro-upstream/feature/PKCE

  Show description for cbc646f
  HEllRZA

  authored
  cbc646f

  Copy full SHA for cbc646f