Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc regarding health check #1653

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

sdarwin
Copy link
Contributor

@sdarwin sdarwin commented Feb 14, 2020

Hi,
A proposal to remove a "caveat" from the page.
Here are some different supporting factors:

  • The warning is 3 years old.
  • The issue it references has been closed. examples/k8s: no way to query healthz endpoint if dex is running on a custom CA #682.
  • I've tested an instance of k8s dex with TLS & health checks. It worked.
  • The project dex-k8s-authenticator has an example dex chart with TLS & health checks. That's been available for some time.
  • When k8s does a probe: "If scheme field is set to HTTPS, the kubelet sends an HTTPS request skipping the certificate verification." Since certificate verification is skipped, there shouldn't be a problem with a custom CA.

@sdarwin sdarwin requested a review from srenatus February 14, 2020 15:54
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants