Protect admin api #145
Merged
Protect admin api #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admin API now requires a 128 byte base64 encoded secret to be passed in Authorization header, closing up a potential security hole for those who expose this service.
bobbyrullo
force-pushed
the
protect_admin_api
branch
from
c66516a
to
ca15c2a
Compare
| @@ -43,19 +43,27 @@ dex needs a 32 byte base64-encoded key which will be used to encrypt the private | |||
|
|
|||
| `DEX_KEY_SECRET=$(dd if=/dev/random bs=1 count=32 2>/dev/null | base64)` | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
What does this newline do?
|
Looks good! |
|
LGTM! |
bobbyrullo
force-pushed
the
protect_admin_api
branch
from
9d1e8a6
to
5e859da
Compare
|
Thanks @joeatwork |
bcwaldon
added a commit
to bcwaldon/dex
that referenced
this pull request
Dec 10, 2015
Level up logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests made to admin API must have an
Authorizationheader with 128 bytes encoded base64