address reviews

dewniMW · Nov 2, 2022 · 0741458 · 0741458
1 parent d6f0da8
commit 0741458
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...n/identity/organization/management/role/management/service/dao/RoleManagementDAOImpl.java b/...n/identity/organization/management/role/management/service/dao/RoleManagementDAOImpl.java
@@ -721,7 +721,7 @@ private void patchOperationRemove(String roleId, String path) throws Organizatio
                 pathFilterExpression = StringUtils.strip(path.split("\\[")[1].replace("]", "")).toLowerCase();
             } else {
                 throw handleClientException(ERROR_CODE_ORG_ROLE_PATCH_REMOVE_OPERATION_INVALID_FILTER_FORMAT,
-                        StringUtils.strip(path.substring(path.indexOf("[") + 1)));
+                        StringUtils.strip(path.substring(path.indexOf("[") + 1)), roleId);
             }
         }
 
@@ -952,7 +952,8 @@ private void patchRemoveOpWithFilters(String roleId, String filter, String path)
                 }
             }
         } catch (IOException | IdentityException e) {
-            throw handleClientException(ERROR_CODE_ORG_ROLE_PATCH_REMOVE_OPERATION_INVALID_FILTER_FORMAT, filter);
+            throw handleClientException(ERROR_CODE_ORG_ROLE_PATCH_REMOVE_OPERATION_INVALID_FILTER_FORMAT, filter,
+                    roleId);
         }
     }
 

diff --git a/pom.xml b/pom.xml
@@ -398,7 +398,7 @@
         <org.wso2.identity.organization.mgt.imp.pkg.version.range>[1.0.0,2.0.0)
         </org.wso2.identity.organization.mgt.imp.pkg.version.range>
 
-        <identity.organization.management.core.version>1.0.27</identity.organization.management.core.version>
+        <identity.organization.management.core.version>1.0.28</identity.organization.management.core.version>
         <org.wso2.identity.organization.mgt.core.imp.pkg.version.range>[1.0.0,2.0.0)
         </org.wso2.identity.organization.mgt.core.imp.pkg.version.range>