Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use certificates data when InsecureSkipTLSVerify is false for a cluster in case of external run CI #6100

Merged
merged 4 commits into from
Nov 19, 2024
Merged

chore: use certificates data when InsecureSkipTLSVerify is false for a cluster in case of external run CI #6100

merged 4 commits into from
Nov 19, 2024

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Nov 15, 2024 •
edited
Loading

Description

use certificates data when InsecureSkipTLSVerify is false for a cluster in case of external run CI

Fixes #6109

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

kartik-579
kartik-579 requested changes Nov 18, 2024
View reviewed changes
pkg/pipeline/WorkflowService.go Outdated Show resolved Hide resolved
@prakash100198 prakash100198 changed the title fix: use certificates data when InsecureSkipTLSVerify is false for a clust… chore: use certificates data when InsecureSkipTLSVerify is false for a clust… Nov 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@prakash100198 prakash100198 changed the title chore: use certificates data when InsecureSkipTLSVerify is false for a clust… chore: use certificates data when InsecureSkipTLSVerify is false for a cluster in case of external run CI Nov 18, 2024
@prakash100198 prakash100198 merged commit 494eee8 into main Nov 19, 2024
13 of 18 checks passed
@prakash100198 prakash100198 deleted the insecure-tls-oss branch November 19, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik-579 kartik-579 kartik-579 approved these changes

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: use certificates data when InsecureSkipTLSVerify is false for a cluster in case of external run CI
3 participants
@prakash100198 @vikramdevtron @kartik-579