Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ext argo app rbac and missing common features and flux app listing and details with rbac #5528

Merged
merged 79 commits into from
Aug 9, 2024

Conversation

RajeevRanjan27
Copy link
Contributor

Description

Fixes #5527

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Jul 19, 2024

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
141558 Triggered Generic High Entropy Secret 134e08c scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/env-values.yaml View secret
1040826 Triggered Generic Password 7d71b8c manifests/installation-script View secret
2763127 Triggered Generic High Entropy Secret 134e08c scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/secrets-test-values.yaml View secret
9498692 Triggered Generic Password 5cfc651 pkg/gitops/GitOpsConfigService.go View secret
9498692 Triggered Generic Password 5cfc651 pkg/gitops/GitOpsConfigService.go View secret
10220829 Triggered Generic High Entropy Secret 7d71b8c charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 7d71b8c charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret 3c2a7e7 charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret 3c2a7e7 charts/devtron/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

api/k8s/application/k8sApplicationRestHandler.go Outdated Show resolved Hide resolved
api/k8s/application/k8sApplicationRestHandler.go Outdated Show resolved Hide resolved
pkg/argoApplication/ArgoApplicationService.go Outdated Show resolved Hide resolved
pkg/argoApplication/ArgoApplicationService.go Outdated Show resolved Hide resolved
pkg/argoApplication/ArgoApplicationService.go Outdated Show resolved Hide resolved
pkg/fluxApplication/FluxApplicationService.go Outdated Show resolved Hide resolved
prakash100198
prakash100198 previously approved these changes Aug 9, 2024
nishant-d
nishant-d previously approved these changes Aug 9, 2024
Copy link

sonarcloud bot commented Aug 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@RajeevRanjan27 RajeevRanjan27 merged commit c0aac33 into main Aug 9, 2024
7 of 8 checks passed
@RajeevRanjan27 RajeevRanjan27 deleted the feat-ext-argo-app-rbac branch August 9, 2024 13:14
This was referenced Aug 23, 2024
@RajeevRanjan27 RajeevRanjan27 changed the title feat: ext argo app rbac and missing common features feat: ext argo app rbac and missing common features and flux app listing and details with rbac Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Missing Common features on External Argo Dashboard app Detail Page
4 participants