Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tls support for git and gitops #5305

Merged
merged 50 commits into from
Aug 2, 2024
Merged

feat: tls support for git and gitops #5305

merged 50 commits into from
Aug 2, 2024

Conversation

iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Jun 14, 2024

Description

Fixes #4659

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented Jun 14, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9498692 Triggered Generic Password bd746ca pkg/gitops/GitOpsConfigService.go View secret
9498692 Triggered Generic Password bd746ca pkg/gitops/GitOpsConfigService.go View secret
141558 Triggered Generic High Entropy Secret 8badcf2 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/env-values.yaml View secret
2763127 Triggered Generic High Entropy Secret 8badcf2 scripts/devtron-reference-helm-charts/statefulset-chart_5-1-0/secrets-test-values.yaml View secret
9498692 Triggered Generic Password c23ff3f pkg/gitops/GitOpsConfigService.go View secret
9498692 Triggered Generic Password afbca2b pkg/gitops/GitOpsConfigService.go View secret
10220829 Triggered Generic High Entropy Secret eb8fbb7 charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret eb8fbb7 charts/devtron/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

vikramdevtron
vikramdevtron previously approved these changes Aug 2, 2024
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@iamayushm iamayushm merged commit 15edcfd into main Aug 2, 2024
7 of 10 checks passed
@iamayushm iamayushm deleted the feat-git-tls-support branch August 2, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Integrate ConfigMap Support into CI-Runner Workflow/Job
3 participants