-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): convert last few routes to use token instead of old models #1195
Merged
ollibowers
merged 17 commits into
331-staging
from
refactor/api/tokenify-payload-routes
Sep 12, 2024
Merged
feat(api): convert last few routes to use token instead of old models #1195
ollibowers
merged 17 commits into
331-staging
from
refactor/api/tokenify-payload-routes
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martanman
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
justjo3l
pushed a commit
that referenced
this pull request
Sep 20, 2024
…#1195) * fix: change eslint rules so frontend can compile with unused variables * wip: created mirrored prepareUserPayload backend helper and converted * fix: tokenified the route * fix: coursesUnlockedWhenTaken and getAllUnlocked tests now use tokens * remove prepareUserPayload from frontend * feat: created function, and finally removed old UserData model * fix: unselect tests now use token * added note into unselectCourse route * fix: aligned mark mappings to the WAM spec * wip: move out convert_to_planner_data * feat: removed model and reworked route * fix: convert ctf to fully use user Storage * feat: convert /validateTermPlanner to no longer use old models * fix: update frontend mark parsing to match backend * fix: re-enable circular imports pylint and remove type keyword * fix: remove potentially bad load_dotenv * fix: remove unused props for CourseDescriptionPanel and CourseMenu after tokenifying last routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr
Storage
: the current in-use database representation (to be soon removed since we have the new database models)User
: the algorithm representationmajor
/courses/getAllUnlocked
/courses/unselectCourse/{course}
/courses/coursesUnlockedWhenTaken/{course}
/ctf/validateCtf
(indirectly)/planner/autoplanning
user_storage_to_algo_user(Storage) -> User
as the fundamental bridge between the main two user representationsget_all_course_states_for_user(User) -> CourseStates
from/courses/getAllUnlocked
bodyparse_mark_to_int(Mark) -> Optional[int]
user_storage_to_raw_plan(Storage) -> RawUserPlan
to attach UOC and Marks to user planner (for easier term validation)fix_user_data
(previously used to add UOC to old planner dicts)convert_to_planner_data
andValidPlannerData
(previously used forvalidate_terms
)UserData
(previously used by payload routes)ValidCourseState
andValidCoursesState
PlannerData
(previously used by autoplanning)prepareUserPayload
frontend helpervalidate_terms
function to use newRawUserPlan
typemarkMap
from backend, and unified all letter grade conversionsminor
User::load_json