Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(fe): cleanup leftover api requests #1166

Merged
merged 13 commits into from
Jul 30, 2024
Merged

chore(fe): cleanup leftover api requests #1166

merged 13 commits into from
Jul 30, 2024

Conversation

ollibowers
Copy link
Collaborator

@ollibowers ollibowers commented Jul 27, 2024 •
edited
Loading

Refactoring frontend to move out any last axios requests into the api folder, and hopefully any last useEffects too!!!
This is pretty thorough, but I have spent too much time on it.

Changes:

  • re-enable backend tests in pipeline (and fix the test utility so it can)
  • rename and combine some frontend api request helper files
  • moved out all last axios requests into the api utils folder
  • moved out some helpers into the api utils folder
    • this has left some helpers slightly different in error handling (logs vs throws), but this will be unified soon (ticket for it)
  • converted last few api useEffects to be useQuerys
    • except for course search, this could still be done with debounced dependencies but will get this to happen in the react query refactor (ticket for it)
    • the only spot that really uses api helpers directly is like ImportPlannerMenu and the Auth boundaries (which I wanted to keep separate from the query cache)
  • deleted a couple unused api helpers

@ollibowers
feat: re-enable backend tests in ci
60b23f0
@ollibowers
hotfix: moved the env setup in test utilities above the connections
0c0ba65
@ollibowers
fix: moved out /courses/getCourse, /courses/getPathFrom and /courses/…
8beb9d7 
…courseChildren

Also deleted a unused helper.
@ollibowers
fix: moved out timetable request
9cc6797
@ollibowers
fix: moved out coursesUnlockedWhenTaken, and consolidated courses.ts …
1bc47de 
…into course.ts
@ollibowers
fix: move out /programs/getPrograms and fold programApi.ts into progr…
992700b 
…amsApi.ts
@ollibowers
fix: move specialisation api calls into specsApi.ts, upgrading useEff…
ce8d607 
…ects to useQuerys in degree wizard.
@ollibowers
fix: move /user/updateDegreeLength, /user/toggleSummerTerm, /user/upd…
4005ba5 
…ateStartYear, /planner/toggleTermLocked into api folder
@ollibowers
fix: moved out ctf axios (lol) and finished last few others
a4c896c
@ollibowers ollibowers requested review from a team as code owners July 27, 2024 05:57
@ollibowers ollibowers marked this pull request as draft July 27, 2024 05:58
@ollibowers ollibowers removed the request for review from a team July 27, 2024 05:58
@ollibowers
Copy link
Collaborator Author

(sorry platform for the review ping, u dont need to review this)

@ollibowers ollibowers marked this pull request as ready for review July 29, 2024 13:54
@ollibowers ollibowers merged commit cd736b4 into 331-staging Jul 30, 2024
8 checks passed
@ollibowers ollibowers deleted the fix/fe/abstract-all-leftover-axios branch July 30, 2024 10:28
@ollibowers ollibowers mentioned this pull request Jul 30, 2024
Closed
@ollibowers ollibowers linked an issue Jul 30, 2024 that may be closed by this pull request
refactor the api requests folder on frontend #1173
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor the api requests folder on frontend
1 participant
@ollibowers