Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the view on unilective on the context menu #1140

Merged

Conversation

jacksonwanggg
Copy link

@jacksonwanggg jacksonwanggg commented May 26, 2024

image

@jacksonwanggg jacksonwanggg requested review from a team as code owners May 26, 2024 08:25
@jacksonwanggg jacksonwanggg linked an issue May 26, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 26, 2024

Test Results

158 tests  ±0   92 ✅ ±0   42s ⏱️ -1s
 13 suites ±0    2 💤 ±0 
  2 files   ±0   64 ❌ ±0 

For more details on these failures, see this check.

Results for commit d2509c7. ± Comparison against base commit 9108b32.

♻️ This comment has been updated with latest results.

@lhvy lhvy changed the base branch from dev to 331-staging June 9, 2024 12:50
@ollibowers ollibowers changed the base branch from 331-staging to 331-staging-backup June 19, 2024 13:09
@ollibowers ollibowers changed the base branch from 331-staging-backup to 331-staging June 19, 2024 13:09
@jacksonwanggg jacksonwanggg force-pushed the feat/fe/1132/adding-unilective-link-context-menu branch from 379d0d4 to 58f0c03 Compare June 21, 2024 06:52
Copy link
Collaborator

@ollibowers ollibowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small fix, otherwise looks good to me!

frontend/src/pages/TermPlanner/ContextMenu/ContextMenu.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@ollibowers ollibowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@jacksonwanggg jacksonwanggg merged commit 620cf27 into 331-staging Jul 4, 2024
1 of 4 checks passed
@jacksonwanggg jacksonwanggg deleted the feat/fe/1132/adding-unilective-link-context-menu branch July 4, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "view course on unilectives" button in the context menu
2 participants