Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend) Add Unilectives reviews to course selector #1109

Merged
merged 6 commits into from
Apr 7, 2024
Merged

feat(frontend) Add Unilectives reviews to course selector #1109

merged 6 commits into from
Apr 7, 2024

Conversation

lhvy
Copy link
Contributor

@lhvy lhvy commented Mar 28, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

Test Results

24 tests   13 ✅  0s ⏱️
12 suites   0 💤
 1 files    11 ❌

For more details on these failures, see this check.

Results for commit f9bb32c.

♻️ This comment has been updated with latest results.

@lhvy
Copy link
Contributor Author

lhvy commented Mar 28, 2024 •
edited
Loading

Draft waiting for 331 to be merged. Early review would be appreciated though! Changed to target bring-to-dev

@lhvy lhvy changed the base branch from dev to bring-to-dev March 28, 2024 05:03
@lhvy lhvy marked this pull request as ready for review March 28, 2024 05:20
@lhvy lhvy requested a review from a team as a code owner March 28, 2024 05:20
Base automatically changed from bring-to-dev to 331-staging March 29, 2024 12:14
@ollibowers ollibowers requested a review from a team as a code owner March 29, 2024 12:14
@ollibowers ollibowers changed the base branch from 331-staging to dev March 29, 2024 12:24
@ollibowers ollibowers changed the base branch from dev to 331-staging March 29, 2024 12:25
@ollibowers ollibowers closed this Mar 29, 2024
@ollibowers ollibowers reopened this Mar 29, 2024
@martanman martanman closed this Mar 29, 2024
@martanman martanman reopened this Mar 29, 2024
@lhvy lhvy requested a review from ollibowers April 4, 2024 08:31
@lhvy lhvy self-assigned this Apr 5, 2024
@lhvy lhvy requested a review from ollibowers April 7, 2024 04:03
ollibowers
ollibowers approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@ollibowers ollibowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm lgtm lgtm gskjflkdjskldfjiosfjoisdj foisd jfio jsdoif sf

@lhvy lhvy merged commit dd14866 into 331-staging Apr 7, 2024
@lhvy lhvy deleted the unilectives branch April 7, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollibowers ollibowers ollibowers approved these changes

@lhjt lhjt lhjt approved these changes

Assignees

@lhvy lhvy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lhvy @lhjt @ollibowers @martanman