Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
inspector: only write coverage in fully bootstrapped Environments
The NODE_V8_COVERAGE folder and the source map computation are setup during pre-execution since they rely on environment variables as well as JS states. Therefore, we need to give up serialization of JS coverage profiles for Environments that have not go through pre-execution. Currently this is only possible for Environments created using the embedder API CreateEnvironment(). As a result we won't have JS coverage data for most cctests, but if that proves to be necessary we could just run lib/internal/main/environment.js for these Environments created for cctests. Fixes: nodejs#32912 Refs: nodejs@65e18a8 Refs: nodejs@5bf4372 nodejs@8aa7ef7 PR-URL: nodejs#32960 Refs: nodejs@8aa7ef7 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
- Loading branch information