Resolving spawn function, removed deprecated extractor state field (#7)

https://app.devrev.ai/devrev/works/ISS-129565 https://app.devrev.ai/devrev/works/ISS-129173
devrev · Nov 21, 2024 · 427eb4b · 427eb4b
1 parent 05206f2
commit 427eb4b
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -2,6 +2,10 @@
 
 ## Release Notes
 
+#### v1.0.1
+
+- Bug fixes and improvements in logging.
+
 #### v1.0.0
 
 - Allow extractions to use full lambda runtime and gracefully handle execution context timeout.

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@devrev/ts-adaas",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Typescript library containing the ADaaS(AirDrop as a Service) control protocol.",
   "type": "commonjs",
   "main": "./dist/index.js",

diff --git a/src/tests/test-helpers.ts b/src/tests/test-helpers.ts
@@ -54,9 +54,6 @@ export function createEvent({
         error,
         delay,
       },
-      extractor_state: {
-        test_extractor_state_key: 'test_extractor_state_value',
-      },
       ...payloadOverrides,
     },
     execution_metadata: {

diff --git a/src/types/common.ts b/src/types/common.ts
@@ -32,7 +32,6 @@ export interface LogRecord {
  */
 export interface AdapterUpdateParams {
   artifact?: Artifact;
-  extractor_state?: object;
 }
 
 /**

diff --git a/src/types/extraction.ts b/src/types/extraction.ts
@@ -160,8 +160,6 @@ export interface AirdropMessage {
   event_context: EventContextIn;
   event_type: EventType;
   event_data?: EventData;
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  extractor_state?: any;
 }
 
 /**
@@ -171,6 +169,5 @@ export interface AirdropMessage {
 export interface ExtractorEvent {
   event_type: string;
   event_context: EventContextOut;
-  extractor_state?: string;
   event_data?: EventData;
 }
diff --git a/src/workers/spawn.ts b/src/workers/spawn.ts
@@ -147,8 +147,8 @@ export class Spawn {
       this.logger.info('Worker exited with exit code: ' + code + '.');
       if (this.timer) {
         clearTimeout(this.timer);
-        await this.exitFromMainThread();
       }
+      await this.exitFromMainThread();
     });
     worker.on(WorkerEvent.WorkerMessage, async (message) => {
       if (message?.subject === WorkerMessageSubject.WorkerMessageEmitted) {
@@ -173,6 +173,7 @@ export class Spawn {
 
   private async exitFromMainThread(): Promise<void> {
     if (this.hasWorkerEmitted) {
+      this.resolve(true);
       return;
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,7 +32,6 @@ export interface LogRecord { @@
      */
     export interface AdapterUpdateParams {
       artifact?: Artifact;
-      extractor_state?: object;
     }
     /**
@@ Expand Down @@