-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 feat criao de conta e perfil de usurio #11
base: dev
Are you sure you want to change the base?
Conversation
…ra serial (auto incrementação)
src/controllers/user.controller.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌👌👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌👌👌NICE!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uma dúvida. Eu tinha entendido que o mockup seriam dados fictícios usados para o teste. Então aqueles bodys que eu criei com os dados para a execução já não seriam mockups? Se não, como seria a implementação dos mockups da forma correta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eles são, tecnicamente, mas não estão estruturados utilizando as ferramentas de mock do jest, isso, por exemplo atrasa o dev de vcs por vcs terem q refazer as entradas dos dados toda vez q precisar de uma entrada p teste, além de n permitir utilização de entradas automáticas. Abaixo tem uns links q podem ser úteis pra vcs entenderem melhor:
- Mocking React Components and Functions using Jest for Beginners - React.js Testing Tutorial #5
- API Testing with Jest Mocks and SuperTest
- How to Perform Mocking in Jest: Complete Walkthrough
- Node.js API [C02P01-3] - 😮Como utilizar Jest com Typescript da maneira certa com Jest Mocks <- esse daqui usa axios, o que é uma biblioteca antiga p fazer as conexões do back, mas vale o aprendizado tbm.
dá uma olhada e dps me fala se entendeu 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ook estou entendendo. Vou tentar implementar na minha feat até a daily de hoje. 🤝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall está bom o PR, apenas alguns ajustes nos titulos dos testes e está ok
Uma sugestão para o futuro, ao implementar testes é utilizar MOCKS. 👍👍
Co-authored-by: Guilherme Bernardo <[email protected]>
Co-authored-by: Guilherme Bernardo <[email protected]>
Co-authored-by: Guilherme Bernardo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌👌👌
Solicitação de merge para a feat de criação de conta e perfil de usuário.