Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 feat criao de conta e perfil de usurio #11

Open
wants to merge 23 commits into
base: dev
Choose a base branch
from

Conversation

MrErykCardoso
Copy link

Solicitação de merge para a feat de criação de conta e perfil de usuário.

@heyitsmepablo heyitsmepablo self-assigned this Aug 22, 2024
@heyitsmepablo heyitsmepablo added the enhancement New feature or request label Aug 22, 2024
@heyitsmepablo heyitsmepablo removed a link to an issue Aug 22, 2024
8 tasks
@heyitsmepablo heyitsmepablo requested review from ed-henrique and GuilhermeBn198 and removed request for ed-henrique August 23, 2024 02:41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌👌

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌👌NICE!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uma dúvida. Eu tinha entendido que o mockup seriam dados fictícios usados para o teste. Então aqueles bodys que eu criei com os dados para a execução já não seriam mockups? Se não, como seria a implementação dos mockups da forma correta?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eles são, tecnicamente, mas não estão estruturados utilizando as ferramentas de mock do jest, isso, por exemplo atrasa o dev de vcs por vcs terem q refazer as entradas dos dados toda vez q precisar de uma entrada p teste, além de n permitir utilização de entradas automáticas. Abaixo tem uns links q podem ser úteis pra vcs entenderem melhor:

dá uma olhada e dps me fala se entendeu 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ook estou entendendo. Vou tentar implementar na minha feat até a daily de hoje. 🤝

Copy link
Member

@GuilhermeBn198 GuilhermeBn198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall está bom o PR, apenas alguns ajustes nos titulos dos testes e está ok

Uma sugestão para o futuro, ao implementar testes é utilizar MOCKS. 👍👍

tests/user.controller.test.js Outdated Show resolved Hide resolved
tests/user.controller.test.js Outdated Show resolved Hide resolved
tests/user.controller.test.js Outdated Show resolved Hide resolved
Copy link
Member

@GuilhermeBn198 GuilhermeBn198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

História 1: Criação de Conta e Perfil de Usuário
3 participants