Python 3.11 #424
Merged
Python 3.11 #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathlib in Python 3.11 implements mkdir and rmdir directly in terms of calling os.<func> without any accessor layer. So copy the implementations of those functions from Python 3.10 to get the previous behavior back. Fixes: devopshq#415 Signed-off-by: Frank Lichtenheld <[email protected]>
Signed-off-by: Frank Lichtenheld <[email protected]>
Python 3.11 replaced _accessor.scandir with _scandir. Override _scandir to still use our implementation. Should be a noop on older Python versions because they didn't have _scandir at all. Fixes: devopshq#396 Signed-off-by: Frank Lichtenheld <[email protected]>
flichtenheld
force-pushed
the
python-3.11
branch
from
da196ca to
326d6f0
Compare
beliaev-maksim
approved these changes
Jul 23, 2023
|
Thank you for fixing these methods! I've also found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see no way of reusing the current versions of mkdir and rmdir from pathlib. So we just need to copy them and implement on our own. The versions here are copied verbatim from Python 3.10.
Edit: Extended the patch to also fix glob. Slightly different problem. We don't need to override glob itself,
but the newly added _scandir which we need to redirect to our accessor.
I implemented a basic UT for mkdir to understand how the UTs work. Note that this UT does not actually test the
bug since it tests directly the ArtifactoryAccessor and not the ArtifactoryPath.
Fixes: #415
Fixes: #396