-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stat: add .created, .last_updated, .last_modified to returned namedtuple #382
Conversation
6c698bc
to
9538da2
Compare
Looks great, can you please add a deprecation notice for old attributes? |
@beliaev-maksim Let's do not do it, it's the standard in other areas and we should keep those fields, it costs nothing to us |
@allburov |
@beliaev-maksim we might add a note about it that |
@allburov |
9538da2
to
db74c8a
Compare
This is consistent with last_updated and last_modified.
This is the same as mtime, for consistency with `last_updated` and `created`.
db74c8a
to
2f120f3
Compare
I've just pushed up updated docstrings, and replaced the one other usage of [cm]time in docs that I could find. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks
This introduces access to
lastUpdated
in the return value, as well as addingctime
andmtime
equivalents with the same naming scheme.