Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stat: add .created, .last_updated, .last_modified to returned namedtuple #382

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

OddBloke
Copy link
Contributor

This introduces access to lastUpdated in the return value, as well as adding ctime and mtime equivalents with the same naming scheme.

@beliaev-maksim
Copy link
Member

Looks great, can you please add a deprecation notice for old attributes?

@allburov
Copy link
Member

@beliaev-maksim Let's do not do it, it's the standard in other areas and we should keep those fields, it costs nothing to us

@beliaev-maksim
Copy link
Member

@allburov
Then it is a confusion to have two fields that do the same. We either deprecate old implicit names or remove newly added

@allburov
Copy link
Member

@beliaev-maksim we might add a note about it that ctime is an alias for created field (the same for mtime), but not the deprecation warning, we don't have the plan to remove them

@beliaev-maksim
Copy link
Member

@allburov
ok, then let's proceed with the note. I think docstrings and docs will be sufficient for this

This is consistent with last_updated and last_modified.
This is the same as mtime, for consistency with `last_updated` and
`created`.
@OddBloke
Copy link
Contributor Author

I've just pushed up updated docstrings, and replaced the one other usage of [cm]time in docs that I could find.

Copy link
Member

@beliaev-maksim beliaev-maksim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@allburov allburov merged commit 383bc11 into devopshq:master Sep 30, 2022
@OddBloke OddBloke deleted the oddbloke/utime branch September 21, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants