update quote_url (#439)

Signed-off-by: Jack Zhang <[email protected]> Fix #417
devopshq · Feb 10, 2024 · 86ed353 · 86ed353
1 parent 2e92742
commit 86ed353
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/artifactory.py b/artifactory.py
@@ -410,13 +410,13 @@ def quote_url(url):
     parsed_url = urllib3.util.parse_url(url)
     if parsed_url.port:
         quoted_path = requests.utils.quote(
-            url.rpartition(f"{parsed_url.host}:{parsed_url.port}")[2]
+            url.partition(f"{parsed_url.host}:{parsed_url.port}")[2]
         )
         quoted_url = (
             f"{parsed_url.scheme}://{parsed_url.host}:{parsed_url.port}{quoted_path}"
         )
     else:
-        quoted_path = requests.utils.quote(url.rpartition(parsed_url.host)[2])
+        quoted_path = requests.utils.quote(url.partition(parsed_url.host)[2])
         quoted_url = f"{parsed_url.scheme}://{parsed_url.host}{quoted_path}"
 
     return quoted_url

diff --git a/tests/unit/test_artifactory_path.py b/tests/unit/test_artifactory_path.py
@@ -100,6 +100,10 @@ def test_quote_url(self):
         check(
             "https://example.com/artifactory/foo", "https://example.com/artifactory/foo"
         )
+        check(
+            "https://example.com/artifactory/foo/example.com/bar",
+            "https://example.com/artifactory/foo/example.com/bar"
+        )
         check(
             "https://example.com/artifactory/foo/#1",
             "https://example.com/artifactory/foo/%231",