Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing some other netlify plugins #13224

Merged
merged 1 commit into from
Sep 5, 2023
Merged

testing some other netlify plugins #13224

merged 1 commit into from
Sep 5, 2023

Conversation

mattstratton
Copy link
Member

No description provided.

@mattstratton mattstratton requested a review from a team as a code owner September 1, 2023 12:56
@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for devopsdays-web ready!

Name Link
🔨 Latest commit 8890324
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/64f1df9daff8860008776051
😎 Deploy Preview https://deploy-preview-13224--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mattstratton
Copy link
Member Author

okay so this definitely does fingerprint the images and assets; the question is are they set with the proper cache...

@mattstratton
Copy link
Member Author

i checked the headers on an image in this deploy preview and they are:

cache-control: public,max-age=31536000,immutable

so that's GOOD!

@mattstratton
Copy link
Member Author

I'm going to go ahead and merge this; if something breaks it's easy to undo.

@mattstratton mattstratton merged commit 2f20156 into main Sep 5, 2023
7 checks passed
@mattstratton
Copy link
Member Author

for the record, this broke pretty hard in production (very long build times and it timed out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant