This repository has been archived by the owner on Jul 21, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
fix the sharing card so all text is readable #434
Comments
I think this is because we don't set a sharing card for twitter; twitter cards are really tough because their rules are that the URL has to be about content, not about a website or whatever. This is the type of card we want to create: https://dev.twitter.com/cards/types/summary-large-image This was the issue I ran into when trying to do this (we can decide if it applies to us or not):
I suppose since we are doing an image that is for the event, it would work out okay... |
mattstratton
added a commit
that referenced
this issue
Mar 27, 2017
Fixes #436 Fixes #434 Signed-off-by: Matt Stratton <[email protected]>
ghost
assigned mattstratton
Mar 27, 2017
ghost
added
the
needs-review
label
Mar 27, 2017
ghost
removed
the
needs-review
label
Mar 27, 2017
I'm re-opening this until we can validate it after the merge of #437 |
Tested and this is fixed in master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Expected behavior
People would be able to read, at minimum, the word "devopsdays". Ideally, the sharing image would be shifted over so the text is readable and there are fewer "brain" gears in the sharing field of vision.
Actual behavior
Possibly because of it choosing the center of the image, we see lots of the "brain" gears but little of the text.
Reproduction Steps
Share the URL https://www.devopsdays.org on Twitter and go look at the tweet in the browser.
The text was updated successfully, but these errors were encountered: