This repository has been archived by the owner on Jul 21, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Speakers page needs to be backwards-compatible #313
Comments
Good catch! We made the talk pages backwards compatible, but I didn't check for the speakers page. I'll file a bug and work on this. |
mattstratton
changed the title
Speakers links does not work
Speakers page needs to be backwards-compatible
Feb 24, 2017
mattstratton
added a commit
that referenced
this issue
Feb 24, 2017
Fixes #313 Signed-off-by: Matt Stratton <[email protected]>
@funkydorian can you verify if https://deploy-preview-314--devopsdays-theme.netlify.com/events/2017-istanbul/welcome/ contains the link the way you expect? |
Yes mostly
Better if the image and the name-surname is on same level (Now there is a
bit difference)
…On Fri, Feb 24, 2017 at 6:45 PM, Matt Stratton ***@***.***> wrote:
@funkydorian <https://github.com/funkydorian> can you verify if
https://deploy-preview-314--devopsdays-theme.netlify.com/
events/2017-istanbul/welcome/ contains the link the way you expect?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#313 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIVzTH3EtxNCkMQrw4kA_cO6PFp6gTrzks5rfvsXgaJpZM4MK2Wj>
.
--
--
D. SEZEN (Mr.)
|
Yup. I figure that's a minor style thing that I was working on. Since you only have two speakers right now, shortly after we release the new theme, I can update your speaker setup to use the new system rather than the datafile method, which will give you the "nicer" speakerpage layout. |
Try loading https://deploy-preview-314--devopsdays-theme.netlify.com/events/2017-istanbul/speakers now (reload the page) and the names should align with the images now :) |
Yeah coool!! Now ok!
…On Fri, Feb 24, 2017 at 7:23 PM, Matt Stratton ***@***.***> wrote:
Try loading https://deploy-preview-314--devopsdays-theme.netlify.com/
events/2017-istanbul/speakers now (reload the page) and the names should
align with the images now :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#313 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIVzTJdWItxutqdjlMHn-OI8W_OlULeaks5rfwQCgaJpZM4MK2Wj>
.
--
--
D. SEZEN (Mr.)
|
mattstratton
added a commit
that referenced
this issue
Feb 24, 2017
* Make speaker page backwards-compatible Fixes #313 Signed-off-by: Matt Stratton <[email protected]> * Align old speaker bio with image
ghost
removed
the
needs-review
label
Feb 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Expected behavior
When i click speakers link, i should see the image and bio of the speakers
Actual behavior
Not exist
Reproduction Steps
https://dev.devopsdays.org/events/2017-istanbul/welcome/
Click to the speakers
https://dev.devopsdays.org/events/2017-istanbul/speakers
Should be like here:
https://www.devopsdays.org/events/2017-istanbul/speakers/
The text was updated successfully, but these errors were encountered: