Skip to content
This repository has been archived by the owner on Jul 21, 2019. It is now read-only.

Speakers page needs to be backwards-compatible #313

Closed
deryadorian opened this issue Feb 24, 2017 · 6 comments
Closed

Speakers page needs to be backwards-compatible #313

deryadorian opened this issue Feb 24, 2017 · 6 comments
Assignees
Labels
Milestone

Comments

@deryadorian
Copy link

deryadorian commented Feb 24, 2017

Expected behavior

When i click speakers link, i should see the image and bio of the speakers

Actual behavior

Not exist

Reproduction Steps

https://dev.devopsdays.org/events/2017-istanbul/welcome/
Click to the speakers
https://dev.devopsdays.org/events/2017-istanbul/speakers

Should be like here:
https://www.devopsdays.org/events/2017-istanbul/speakers/

@mattstratton mattstratton added this to the v1.0 Release milestone Feb 24, 2017
@mattstratton
Copy link
Member

Good catch! We made the talk pages backwards compatible, but I didn't check for the speakers page. I'll file a bug and work on this.

@mattstratton mattstratton changed the title Speakers links does not work Speakers page needs to be backwards-compatible Feb 24, 2017
mattstratton added a commit that referenced this issue Feb 24, 2017
@mattstratton mattstratton self-assigned this Feb 24, 2017
@ghost ghost added needs-review and removed in progress labels Feb 24, 2017
@mattstratton
Copy link
Member

@funkydorian can you verify if https://deploy-preview-314--devopsdays-theme.netlify.com/events/2017-istanbul/welcome/ contains the link the way you expect?

@deryadorian
Copy link
Author

deryadorian commented Feb 24, 2017 via email

@mattstratton
Copy link
Member

Yup. I figure that's a minor style thing that I was working on. Since you only have two speakers right now, shortly after we release the new theme, I can update your speaker setup to use the new system rather than the datafile method, which will give you the "nicer" speakerpage layout.

@mattstratton
Copy link
Member

Try loading https://deploy-preview-314--devopsdays-theme.netlify.com/events/2017-istanbul/speakers now (reload the page) and the names should align with the images now :)

@deryadorian
Copy link
Author

deryadorian commented Feb 24, 2017 via email

mattstratton added a commit that referenced this issue Feb 24, 2017
* Make speaker page backwards-compatible

Fixes #313

Signed-off-by: Matt Stratton <[email protected]>

* Align old speaker bio with image
@ghost ghost removed the needs-review label Feb 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants